-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to upload and retrieve simulation reports #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
CampGareth
force-pushed
the
feature/simulation-reports-fixed
branch
from
November 6, 2018 11:15
cde744d
to
86e60b0
Compare
CampGareth
commented
Nov 6, 2018
CampGareth
commented
Nov 6, 2018
CampGareth
commented
Nov 6, 2018
CampGareth
commented
Nov 6, 2018
CampGareth
changed the title
[WIP] add ability to upload and retrieve simulation reports
add ability to upload and retrieve simulation reports
Nov 6, 2018
CampGareth
commented
Nov 7, 2018
CampGareth
force-pushed
the
feature/simulation-reports-fixed
branch
from
November 12, 2018 11:59
8f851db
to
22429ca
Compare
"added to release.md" no but this is the sort of thing that should be since it's user-facing. I mean assuming we had a release.md in this repo. Time to investigate setting one up |
pwaller
suggested changes
Nov 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, nice that the scope is not too large! 💯
A few important suggestions in here though. 📝
CampGareth
force-pushed
the
feature/simulation-reports-fixed
branch
3 times, most recently
from
November 12, 2018 16:58
831ade1
to
567a053
Compare
pwaller
reviewed
Nov 12, 2018
CampGareth
force-pushed
the
feature/simulation-reports-fixed
branch
from
November 12, 2018 17:50
65656e7
to
e342d74
Compare
pwaller
approved these changes
Nov 12, 2018
🎯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we generate area utilisation stats for Builds and store them as reports. These stats give users an idea of how optimised their design is compared to previous versions. You don't have to do a full build to generate these stats however, you can get them from a Simulation. We've added the generation of these reports to reco-sdaccel so now we need platform to offer API endpoints for storing reports.
New API features:
GET /simulations/<id>/reports
POST /simulations/<id>/reports
The POST will be used by workers running Simulations. The GET will be used by
reco
to view stored reports.Checklist