Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong calculating jump adresses #6

Closed
FeelUsM opened this issue Nov 22, 2018 · 1 comment
Closed

Wrong calculating jump adresses #6

FeelUsM opened this issue Nov 22, 2018 · 1 comment
Labels

Comments

@FeelUsM
Copy link

FeelUsM commented Nov 22, 2018

I try to compare result of your disassemler and https://onlinedisassembler.com/odaweb/strcpy_x86
and in this example (strcpy_x86) at address 000000001d I see wrong address for jne command
ODA: jne 00000010 (loop lable at address 00000010)
your: jne 00000110 (if EIP=00000000)

@Recoskie Recoskie added the bug label Dec 15, 2018
Recoskie added a commit that referenced this issue Dec 15, 2018
Relative address bug fix.
Recoskie added a commit that referenced this issue Dec 15, 2018
@Recoskie
Copy link
Owner

Hey thanks for finding this bug. It seems the sing bit was carried outside the address. The relative address should come out to the proper address location now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants