feat: Add onRowClick handler for interactive table rows #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add optional onRowClick prop to TableWrapper interface - Enable click handler for drill-down interactions - Add visual feedback with cursor pointer and hover state - Backward compatible - existing tables unchanged - Uses PatternFly's isHoverable for consistent styling - Tested in OCM Genie POC with 100+ row tables This feature enables common use cases like: - Navigating to detail pages - Opening modals/drawers - Selecting items for actions - Expanding inline details
|
@lkrzyzanek |
- Add 14 new test cases for onRowClick functionality - Test row click handler with correct data passing - Test visual feedback (cursor pointer, hover state) - Test edge cases: null values, arrays, large tables (150 rows) - Test backward compatibility (tables without onRowClick) - Test multiple clicks and data-testid attributes - All 24 tests passing ✓
|
@jschuler ready for review, added test coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature enables common use cases like: