Refactor config source to not keep in memory all the properties #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sgitario
force-pushed
the
jcarvaja/SWATCH-2037
branch
from
6ad7543 to
5c0fbee
Compare
gwenneg
reviewed
Apr 2, 2024
src/main/java/com/redhat/cloud/common/clowder/configsource/utils/CertUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redhat/cloud/common/clowder/configsource/ClowderConfigSource.java
Outdated
Show resolved
Hide resolved
...a/com/redhat/cloud/common/clowder/configsource/handlers/KafkaSaslClowderPropertyHandler.java
Outdated
Show resolved
Hide resolved
...a/com/redhat/cloud/common/clowder/configsource/handlers/KafkaSaslClowderPropertyHandler.java
Outdated
Show resolved
Hide resolved
...edhat/cloud/common/clowder/configsource/handlers/PrivateEndpointsClowderPropertyHandler.java
Outdated
Show resolved
Hide resolved
|
We'll need an additional handler for the quarkus-unleash configuration. |
gwenneg
reviewed
Apr 2, 2024
src/main/java/com/redhat/cloud/common/clowder/configsource/ClowderConfigSource.java
Show resolved
Hide resolved
src/main/java/com/redhat/cloud/common/clowder/configsource/ClowderConfigSource.java
Show resolved
Hide resolved
src/test/java/com/redhat/cloud/common/clowder/configsource/ConfigSourceTest.java
Outdated
Show resolved
Hide resolved
|
@Sgitario ☝️ Sorry for the delay before this was reviewed. |
Sgitario
force-pushed
the
jcarvaja/SWATCH-2037
branch
from
5c0fbee to
ce57b57
Compare
gwenneg
reviewed
Apr 3, 2024
...m/redhat/cloud/common/clowder/configsource/handlers/KafkaSecurityClowderPropertyHandler.java
Outdated
Show resolved
Hide resolved
src/test/java/com/redhat/cloud/common/clowder/configsource/ConfigSourceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/redhat/cloud/common/clowder/configsource/ConfigSourceTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redhat/cloud/common/clowder/configsource/ClowderConfigSourceFactory.java
Outdated
Show resolved
Hide resolved
…wderConfigSourceFactory.java Co-authored-by: Gwenneg Lepage <gwenneg@users.noreply.github.com>
…figSourceTest.java Co-authored-by: Gwenneg Lepage <gwenneg@users.noreply.github.com>
Sgitario
force-pushed
the
jcarvaja/SWATCH-2037
branch
from
1887435 to
569481e
Compare
|
@gwenneg PR updated with your latest comments. |
|
I forgot that It'd be easier if this project was released like the Quarkiverse extensions! |
ups, sorry. Will follow this pattern for the next time! |
|
I just released 2.6.0. It'll be available in Maven Central soon-ish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before these changes, the Clowder config source was keeping in memory all the properties from all the sources in the existingValues property. Apart from this, the clowder config source was used even when the clowder file is not set.
This pull request addresses both issues by:
This interface implements a decorator pattern, so the config source will only keep the properties in memory if and only if there is any handler that handles it.
Relates to SWATCH-2037