Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make proxy image configurable and update default image #1177

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Make proxy image configurable and update default image #1177

wants to merge 6 commits into from

Conversation

adamrdrew
Copy link
Contributor

This adds the following

  • CaddyProxy Image to the ClowdEnvironment spec
  • CaddyProxy Image to the Clowder config
  • New getter to get the correct image version from either spec, clowder config, or default
  • Add getter to where we construct the proxy resource
  • Bumped to the latest caddy-ubi

@adamrdrew
Copy link
Contributor Author

Something worth considering with this. Our default image will now come from a Konflux repo rather than cloudservices. That means a pull secret is required. Of course it can be overridden in config, but our default wont work anywhere but our clusters. Maybe not great?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adamrdrew