-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHCLOUD-27862] add Pod Lifecyle hooks #830
Conversation
Can you run |
4616dd3
to
5639bf8
Compare
Done! I will note, I have not done any testing of these changes at all yet. I was going to see if I can get this working, and then see if yall had any thoughts on these changes to the Spec. |
5639bf8
to
9ef4bf6
Compare
8e72059
to
1ebda3f
Compare
I have no problem with the spec changes |
1ebda3f
to
d22a556
Compare
d22a556
to
5dcba94
Compare
40c6243
to
87e5042
Compare
6d6c8f1
to
ada8036
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM really, but a couple of questions before approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry just a couple minor doc generator things again
docs/appconfig/schema-definitions-dependencyendpoint-properties-apipaths-items.md
Outdated
Show resolved
Hide resolved
docs/appconfig/schema-definitions-dependencyendpoint-properties-apipaths.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll sort out those doc generation shenanigans later, it doesn't need to hold up this PR
Pending test outcome I'm happy to merge this |
/retest |
https://issues.redhat.com/browse/RHCLOUD-27862
minimal example (use the example clowdenv.yml):
(These hooks are a variation from: https://thecloudblog.net/lab/kubernetes-container-lifecycle-events-and-hooks/. The
echo "message" > /proc/1/fd/1
prints that message to the pod logs so we can see the hooks in action)The deployment generated by this clowdapp contains:
Using this image and lifecycle hooks, open the pod terminal and see the printed log messages. The readiness/liveness probes will fail for this container. So when the pod restarts, we can see the preStop hook just before the sigquit was received: