Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty dynaconfEnvName now that 'env' is supported #872

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Allow empty dynaconfEnvName now that 'env' is supported #872

merged 1 commit into from
Oct 11, 2023

Conversation

bsquizz
Copy link
Contributor

@bsquizz bsquizz commented Oct 9, 2023

Related to #855 -- 'omitempty' should have been set on this field

This was referenced Oct 9, 2023
Merged
Merged
psav
psav reviewed Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@psav psav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind the extra changes in this - but I'd like to check with you to ensure that you are running a newer version than I, then I can update!

@psav psav added technical debt Technical Debt related pr-architectural-change Required architect sign-off labels Oct 10, 2023
@bsquizz
Copy link
Contributor Author

bsquizz commented Oct 10, 2023

I don't mind the extra changes in this - but I'd like to check with you to ensure that you are running a newer version than I, then I can update!

I was wondering about this too because I just re-fetched the doc tools yesterday. I'm wondering if we should pin these in the doc generation scripts so everyone has consistency when they run make api-docs (that can be a follow-up PR). Here's what I have now:

❯ cd crd-ref-docs
❯ git rev-parse HEAD
365ecbe3898eee7d95858dba7e13d4903d2faefb

❯ asciidoctor -v
Asciidoctor 2.0.20 [https://asciidoctor.org]
Runtime Environment (ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x86_64-linux]) (lc:UTF-8 fs:UTF-8 in:UTF-8 ex:UTF-8)

❯ docs/build/node_modules/.bin/jsonschema2md --version
4.2.2

Let me know if you're using something different and I bump down to a lower version

@psav psav merged commit 4a6c848 into master Oct 11, 2023
5 checks passed
@psav psav deleted the omit_empty_dynaconf_env branch February 20, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psav psav psav approved these changes

Assignees
No one assigned
Labels
pr-architectural-change Required architect sign-off technical debt Technical Debt related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsquizz @psav