Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new ephem-msk mode #873

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Added new ephem-msk mode #873

merged 3 commits into from
Nov 3, 2023

Conversation

psav
Copy link
Collaborator

@psav psav commented Oct 10, 2023

No description provided.

@psav psav added enhancement New feature or request pr-architectural-change Required architect sign-off labels Oct 10, 2023
@psav
Copy link
Collaborator Author

psav commented Oct 11, 2023

/retest

adamrdrew
adamrdrew approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@adamrdrew adamrdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A hearty LGTM from me. This looks great. Test coverage so I feel safe. The code itself is short, sweet, and imminently readable and I have no questions.

controllers/cloud.redhat.com/providers/kafka/managed.go Show resolved Hide resolved
wcmitchell
wcmitchell approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@wcmitchell wcmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots to cover here, but overall looks good! Definitely think this is something we'll have to push out and let soak to see how it behaves live.

@psav psav merged commit a30e839 into master Nov 3, 2023
5 checks passed
@psav psav deleted the psav/ephem-msk branch February 20, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcmitchell wcmitchell wcmitchell approved these changes

@adamrdrew adamrdrew adamrdrew approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request pr-architectural-change Required architect sign-off
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psav @adamrdrew @wcmitchell