Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurable go version for Makefile #902

Merged

Conversation

Victoremepunto
Copy link
Contributor

No description provided.

@Victoremepunto Victoremepunto marked this pull request as ready for review December 5, 2023 14:55
Copy link
Contributor

@wcmitchell wcmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@psav
Copy link
Collaborator

psav commented Dec 15, 2023

I'd love to understand what the usecase for this is. I'm not against the change, just wanted to understand it.

@Victoremepunto
Copy link
Contributor Author

I'd love to understand what the usecase for this is. I'm not against the change, just wanted to understand it.

Running the deploy-minikube-quick Makefile target on a newer go version (I'm using 1.21.5) yields errors. I created this PR so that you could configure the Go version without having to modify the Makefile nor the local go version. I'm open to suggestions

@psav psav merged commit 02384b8 into RedHatInsights:master Dec 18, 2023
5 of 6 checks passed
@Victoremepunto Victoremepunto deleted the configure-go-version-makefile branch December 18, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants