Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(metrics): Refactor to use built-in library function #937

Merged
merged 1 commit into from
Feb 23, 2024
Merged

refactor(metrics): Refactor to use built-in library function #937

merged 1 commit into from
Feb 23, 2024

Conversation

psav
Copy link
Collaborator

@psav psav commented Feb 22, 2024

  • Replacing custom List call with a pre-built function
  • Passes in ClowdEnv now

@psav
refactor(metrics): Refactor to use built-in library function
bb6fddc 
* Replacing custom List call with a pre-built function
* Passes in ClowdEnv now
@psav psav requested a review from mjholder February 22, 2024 18:27
mjholder
mjholder approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@mjholder mjholder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like the improvements and refactoring to use existing functions.

@psav psav merged commit 6f80d1d into master Feb 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjholder mjholder mjholder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psav @mjholder