Skip to content

Conversation

@hosekadam
Copy link
Contributor

Description

description text...

Jira link:
RSPEED-XXX


Screenshots

Before:

After:


Checklist ☑️

  • PR only fixes one issue or story
  • Change reviewed for extraneous code
  • UI best practices adhered to
  • Commits squashed and meaningfully named
  • All PR checks pass locally (build, lint, test, E2E)

  • (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
  • (Optional) QE: Has been mentioned
  • (Optional) UX: Needs UX attention (end user UX modified, missing designs)
  • (Optional) UX: Has been mentioned

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (pf6-upgrade@fcb2370). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             pf6-upgrade     #237   +/-   ##
==============================================
  Coverage               ?   61.67%           
==============================================
  Files                  ?       40           
  Lines                  ?     7306           
  Branches               ?      691           
==============================================
  Hits                   ?     4506           
  Misses                 ?     2773           
  Partials               ?       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-watson
Copy link
Contributor

Looks pretty good, just a few comments. The items in the expanded section should be in line with the name column and title. Potentially Affected Systems needs to be in one line instead of multiple. The height of the filter buttons for Deprecations, Changes and Additions can be reduced to 110. Lastly for now we can stick with the light blue (--pf-t--global--color--nonstatus--blue--default) for info icons until we get the mocks from UX.
image

@hosekadam
Copy link
Contributor Author

Thanks for the review! Fixed the details to be aligned.

About the blue, I think the original one was more like --pf-t--global--icon--color--severity--none--default, so I used that one. Also, I remember I asked John how we should handle the color of info as it got changed from blue to purple. He said I should use there the same color as you. So I understood it, we can use default info color for additions, but it's probably meant like the color of uninstalled/upcoming in lifecycle which makes sense, it's something new. If we decide for a different approach, the colors are in a separate commit.

Screenshot From 2025-11-21 16-00-37

@pr-watson
Copy link
Contributor

Looks good Adam, let's take this to John and see what he thinks. I also noticed that the column name font sizes have decreased a bit so I'd like to ask John for his opinion there too. If so i'll update the size for the Life Cycle table as well

Copy link
Contributor

@pr-watson pr-watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hosekadam
Copy link
Contributor Author

Removed the redundant dividing line when row is expanend:

Screenshot From 2025-11-26 11-51-00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants