Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

groups-migration: edge-parity groups migration. #2245

Merged
merged 2 commits into from
Oct 4, 2023
Merged

groups-migration: edge-parity groups migration. #2245

merged 2 commits into from
Oct 4, 2023

Conversation

ldjebran
Copy link
Contributor

Description

In the context of edge-parity implement the groups migration script.

FIXES: https://issues.redhat.com/browse/THEEDGE-3537

Type of change

What is it?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Tests update
  • Refactor

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I run make pre-commit to check fmt/vet/lint/test-no-fdo

@mergify mergify bot added the new feature New feature label Sep 27, 2023
@ldjebran
Copy link
Contributor Author

/retest

4 similar comments
@ldjebran
Copy link
Contributor Author

/retest

@ldjebran
Copy link
Contributor Author

/retest

@de1987
Copy link
Contributor

de1987 commented Sep 27, 2023

/retest

@ldjebran
Copy link
Contributor Author

/retest

@ldjebran ldjebran force-pushed the edge-parity-groups-migration branch from 485b2a3 to 664f2ab Compare September 28, 2023 07:56
@ldjebran
Copy link
Contributor Author

/retest

@mergify mergify bot added the waiting for review Need reviewers label Sep 28, 2023
@ldjebran
groups-migration: edge-parity groups migration.
2789e7c 
In the context of edge-parity implement the groups migration script.
FIXES: https://issues.redhat.com/browse/THEEDGE-3537
@ldjebran ldjebran force-pushed the edge-parity-groups-migration branch from 664f2ab to 2789e7c Compare September 28, 2023 08:48
@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

/retest

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

4 similar comments
@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

/retest

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

/retest

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

/retest

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

/retest

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023 •
edited
Loading

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Files Coverage Δ
pkg/clients/inventorygroups/client.go 100.00% <100.00%> (ø)
cmd/migrategroups/migrategroups/migrategroups.go 82.46% <82.46%> (ø)

📢 Thoughts on this report? Let us know!.

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

/retest

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

/retest

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@RedHatInsights RedHatInsights deleted a comment from mergify bot Sep 28, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 3, 2023

This pull request needs all conversation threads to be resolved. Could you fix it @ldjebran? 🙏

@mergify mergify bot added the question Further information is requested label Oct 3, 2023
@mergify mergify bot removed the waiting for review Need reviewers label Oct 3, 2023
@mergify mergify bot removed the question Further information is requested label Oct 3, 2023
acosferreira
acosferreira approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@acosferreira acosferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ldjebran
Copy link
Contributor Author

ldjebran commented Oct 4, 2023

/retest

@mergify mergify bot merged commit 94e6eca into RedHatInsights:main Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@de1987 de1987 de1987 approved these changes

@acosferreira acosferreira acosferreira approved these changes

@maxamillion maxamillion Awaiting requested review from maxamillion

@loadtheaccumulator loadtheaccumulator Awaiting requested review from loadtheaccumulator loadtheaccumulator is a code owner

@AaronH88 AaronH88 Awaiting requested review from AaronH88

@thom-at-redhat thom-at-redhat Awaiting requested review from thom-at-redhat

@mgold1234 mgold1234 Awaiting requested review from mgold1234

@tomershinhar tomershinhar Awaiting requested review from tomershinhar

@omaciel omaciel Awaiting requested review from omaciel

@lahavyuv86 lahavyuv86 Awaiting requested review from lahavyuv86

Assignees
No one assigned
Labels
new feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ldjebran @de1987 @codecov-commenter @acosferreira