Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add group uuid as parameter for deviceview endpoint #2266

Merged

Conversation

acosferreira
Copy link
Contributor

Description

enable group_uuid as parameter to device view endpoint to be able to get list of device based on the insights group

FIXES:

Type of change

What is it?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Tests update
  • Refactor

@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2023

This pull request needs all conversation threads to be resolved. Could you fix it @acosferreira? 🙏

@mergify mergify bot added the question Further information is requested label Oct 17, 2023
Copy link
Contributor

@ldjebran ldjebran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, missing one unittest

@mergify mergify bot removed the question Further information is requested label Oct 17, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2023

This pull request needs all conversation threads to be resolved. Could you fix it @acosferreira? 🙏

@mergify mergify bot added the question Further information is requested label Oct 17, 2023
@mergify mergify bot removed the question Further information is requested label Oct 18, 2023
Copy link
Contributor

@adeliaferreira adeliaferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@mgold1234 mgold1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
pkg/routes/devices.go 60.00% <ø> (+1.95%) ⬆️
pkg/routes/query_params.go 90.47% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@mergify mergify bot merged commit 6d68866 into RedHatInsights:main Oct 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants