-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add group uuid as parameter for deviceview endpoint #2266
add group uuid as parameter for deviceview endpoint #2266
Conversation
This pull request needs all conversation threads to be resolved. Could you fix it @acosferreira? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, missing one unittest
This pull request needs all conversation threads to be resolved. Could you fix it @acosferreira? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
Description
enable group_uuid as parameter to device view endpoint to be able to get list of device based on the insights group
FIXES:
Type of change
What is it?