Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-toolset: update to latest container base version. #2270

Merged
merged 1 commit into from
Oct 17, 2023
Merged

go-toolset: update to latest container base version. #2270

merged 1 commit into from
Oct 17, 2023

Conversation

ldjebran
Copy link
Contributor

@ldjebran ldjebran commented Oct 17, 2023 •
edited
Loading

Description

Update Go Toolset for UBI 8 to latest version as per: https://catalog.redhat.com/software/containers/ubi8/go-toolset/5ce8713aac3db925c03774d1?architecture=amd64&image=652d47582fd993af22f76402&container-tabs=gti

FIXES: https://issues.redhat.com/browse/THEEDGE-3618

Type of change

What is it?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Tests update
  • Refactor

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I run make pre-commit to check fmt/vet/lint/test-no-fdo

@mergify mergify bot added the bug fix Fixes #issue label Oct 17, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

omaciel
omaciel approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@omaciel omaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mergify mergify bot merged commit 770be1c into RedHatInsights:main Oct 17, 2023
6 checks passed
@mergify mergify bot added the waiting for review Need reviewers label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@de1987 de1987 de1987 approved these changes

@omaciel omaciel omaciel approved these changes

@maxamillion maxamillion Awaiting requested review from maxamillion

@acosferreira acosferreira Awaiting requested review from acosferreira

@loadtheaccumulator loadtheaccumulator Awaiting requested review from loadtheaccumulator loadtheaccumulator is a code owner

@AaronH88 AaronH88 Awaiting requested review from AaronH88

@thom-at-redhat thom-at-redhat Awaiting requested review from thom-at-redhat

@mgold1234 mgold1234 Awaiting requested review from mgold1234

@tomershinhar tomershinhar Awaiting requested review from tomershinhar

@lahavyuv86 lahavyuv86 Awaiting requested review from lahavyuv86

Assignees
No one assigned
Labels
bug fix Fixes #issue waiting for review Need reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ldjebran @codecov-commenter @omaciel @de1987