Remove lock files in build and clean step to allow linking #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karelhala
force-pushed
the
remove-lock-files
branch
from
e85c439 to
ef9a69f
Compare
rvsia
approved these changes
Jul 19, 2021
Codecov Report
@@ Coverage Diff @@
## master #1208 +/- ##
=======================================
Coverage 67.80% 67.80%
=======================================
Files 263 263
Lines 5109 5109
Branches 1786 1786
=======================================
Hits 3464 3464
Misses 1458 1458
Partials 187 187 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect linking
Since we are using npm@v7 and its workspaces the linking of a package is somewhat not correct. Based on this reply npm/cli#2036 (comment) it looks like the problem is that we store lock files in each folder. This PR adds a new command to clean and after install to remove such files.