Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transform-imports): Only fallback to alternative icon #2003

Merged
merged 2 commits into from
May 3, 2024
Merged

fix(transform-imports): Only fallback to alternative icon #2003

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69fb21f
fix(transform-imports): Only fallback to alternative icon
bastilian May 2, 2024
4badb09
Merge branch 'master' into transform_icons_fix
Hyperkid123 May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 27 additions & 9 deletions packages/tsc-transform-imports/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,17 +145,35 @@ function camelToDash(str: string) {
return str.replace(/([A-Z])/g, (g) => `-${g[0].toLowerCase()}`).replace(/^-/, '');
}

function iconImportLiteral(icon: string) {
if (ICONS_CACHE[icon]) {
return ICONS_CACHE[icon];
}

const assumedImportName = camelToDash(icon);
const fallbackName = ICONS_NAME_FIX[icon];

if (ICONS_DIRECTORIES.map((root) => glob.sync(`${root}/**/${assumedImportName}.js`)).flat().length > 0) {
ICONS_CACHE[icon] = `@patternfly/react-icons/dist/dynamic/icons/${assumedImportName}`;
}

if (!ICONS_CACHE[icon] && fallbackName && ICONS_DIRECTORIES.map((root) => glob.sync(`${root}/**/${fallbackName}.js`)).flat().length > 0) {
ICONS_CACHE[icon] = `@patternfly/react-icons/dist/dynamic/icons/${fallbackName}`;
}

if (ICONS_CACHE[icon]) {
return ICONS_CACHE[icon];
} else {
throw new Error(
`Cannot find source files for the ${icon} icon. Expected filename ${assumedImportName}. It is possible the icon name does not match the filename pattern. You can look for the source file and add a new entry to the ICONS_NAME_FIX in the @redhat-cloud-services/tsc-transform-imports package.`
);
}
}

function createIconDynamicImports(nodeFactory: ts.NodeFactory, iconNames: string[]) {
const imports = iconNames.map((icon) => {
const nameSpecifier = ICONS_NAME_FIX[icon] || camelToDash(icon);
const importLiteral = `@patternfly/react-icons/dist/dynamic/icons/${nameSpecifier}`;
const exists = ICONS_CACHE[icon] || ICONS_DIRECTORIES.map((root) => glob.sync(`${root}/**/${nameSpecifier}.js`)).flat().length > 0;
if (!exists) {
throw new Error(
`Cannot find source files for the ${icon} icon. Expected filename ${nameSpecifier}. It is possible the icon name does not match the filename pattern. You can look for the source file and add a new entry to the ICONS_NAME_FIX in the @redhat-cloud-services/tsc-transform-imports package.`
);
}
ICONS_CACHE[icon] = importLiteral;
const importLiteral = iconImportLiteral(icon);

return nodeFactory.createImportDeclaration(
undefined,
nodeFactory.createImportClause(false, nodeFactory.createIdentifier(icon), undefined),
Expand Down
Loading