add cypress test to bulk select #1314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkarat
reviewed
Dec 9, 2024
|
|
||
| // select a couple | ||
| // but only ones that can be selected | ||
| cy.get('.pf-v5-c-table__tbody').then(rows => {selectRandomEnabledRows({rows: rows, numberOfRowsToSelect: 3})}); |
There was a problem hiding this comment.
Suggested change
| cy.get('.pf-v5-c-table__tbody').then(rows => {selectRandomEnabledRows({rows: rows, numberOfRowsToSelect: 3})}); | |
| cy.get(TABLE).then(rows => selectRandomEnabledRows({rows: rows, numberOfRowsToSelect: 3})); |
There was a problem hiding this comment.
This one doesn't work - the test gets stuck
| cy.get(':nth-child(2) > .pf-v5-c-menu-toggle').should('have.text', '3 selected') | ||
|
|
||
| // Select None | ||
| cy.get(':nth-child(2) > .pf-v5-c-menu-toggle > .pf-v5-c-menu-toggle__controls').click(); |
There was a problem hiding this comment.
Use PT_BULK_SELECT from FEC to select the bulk select toggle
There was a problem hiding this comment.
PT_BULK_SELECT results in a flaky test. I think it's because it targets the pf-v5-c-menu-toggle element, instead of the pf-v5-c-menu-toggle__controls element. In some cases it then doesn't open the BS menu
|
Your errors are for linting. npm run lint should give you everything you need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Associated Jira ticket: RHINENG-14744
Add Cypress test to Bulk Selector
How to test the PR
run npm test:ct
Before the change
90 tests are run
After the change
At least 91 tests are run, including
The Bulk selector shows the correct number of systems selected.Dependent work link
Checklist: