move localStorage to a cookieg (#954)

RedHatInsights · Sep 10, 2020 · 13c30ad · 13c30ad
1 parent 1029aea
commit 13c30ad
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/src/js/auth.js b/src/js/auth.js
@@ -53,7 +53,7 @@ export default () => {
     // on every page load
     if (token && token.length > 10) {
         options.token = token;
-        options.refreshToken = getWindow().localStorage.getItem(options.cookieName);
+        options.refreshToken = cookie.get('cs_jwt_refresh');
     }
 
     const promise = jwt.init(options).then(bouncer);

diff --git a/src/js/jwt/jwt.js b/src/js/jwt/jwt.js
@@ -190,7 +190,7 @@ function isExistingValid(token) {
 function initSuccess() {
     log('JWT Initialized');
     setCookie(priv.keycloak.token);
-    window.localStorage.setItem(priv.cookie.cookieName, priv.keycloak.refreshToken);
+    setRefresh(priv.keycloak.refreshToken);
 }
 
 // keycloak init failed
@@ -322,6 +322,11 @@ function setCookie(token) {
     }
 }
 
+function setRefresh(refreshToken) {
+    log('Setting the refresh token');
+    cookie.set('cs_jwt_refresh', refreshToken, { secure: true });
+}
+
 // do this so we can mock out for test
 function setCookieWrapper(str) {
     document.cookie = str;

diff --git a/src/js/jwt/jwt.unit.test.js b/src/js/jwt/jwt.unit.test.js
@@ -182,10 +182,6 @@ describe('JWT', () => {
     describe('init and auth functions', () => {
         describe('initSuccess()', () => {
             const initSuccess = jwt.__get__('initSuccess');
-            test('should write to localStorage', () => {
-                initSuccess();
-                expect(window.localStorage.getItem('cs_jwt')).toContain(encodedToken);
-            });
             test('should set a cookie', () => {
                 const mockSetCookie = jest.fn();
                 jwt.__set__('setCookie', mockSetCookie);