Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show link to configure events in notifications drawer for non-admin users #2792

Merged

Conversation

CodyWMitchell
Copy link
Contributor

@CodyWMitchell CodyWMitchell commented Mar 15, 2024

RHCLOUD-31355

  • Display the link to Configure Events in the notifications dropdown for users that have notifications:*:*, notifications:notifications:write, or notifications:notifications:read permissions (as well as Org Admins)

Merge only after: RedHatInsights/chrome-service-backend#434

Before

image

After

image

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 63.21%. Comparing base (85c4063) to head (ca1a7ac).

❗ Current head ca1a7ac differs from pull request most recent head f90dd2d. Consider uploading reports for the commit f90dd2d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2792      +/-   ##
==========================================
- Coverage   63.40%   63.21%   -0.20%     
==========================================
  Files         193      193              
  Lines        4214     4227      +13     
  Branches      851      776      -75     
==========================================
  Hits         2672     2672              
- Misses       1514     1546      +32     
+ Partials       28        9      -19     
Files Coverage Δ
...ponents/NotificationsDrawer/DrawerPanelContent.tsx 4.76% <0.00%> (-1.24%) ⬇️

... and 16 files with indirect coverage changes

@CodyWMitchell CodyWMitchell marked this pull request as draft March 15, 2024 15:15
@CodyWMitchell CodyWMitchell force-pushed the configure_events_read branch 2 times, most recently from fe97598 to 4478522 Compare March 15, 2024 17:51
@CodyWMitchell CodyWMitchell changed the title Show the Configure Events page for non org admin users Show link to configure events in notifications drawer for non-admin users Mar 15, 2024
@CodyWMitchell CodyWMitchell marked this pull request as ready for review March 15, 2024 18:19
@CodyWMitchell CodyWMitchell marked this pull request as draft March 15, 2024 20:21
@karelhala karelhala marked this pull request as ready for review April 18, 2024 08:02
@Hyperkid123 Hyperkid123 merged commit 830ea14 into RedHatInsights:master Apr 18, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants