[RHCLOUD-31672] Add regional ocm api instances #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneelac22
requested review from
Hyperkid123,
ryelo,
karelhala and
florkbr
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2813 +/- ##
=======================================
Coverage 63.27% 63.27%
=======================================
Files 195 195
Lines 4242 4242
Branches 774 774
=======================================
Hits 2684 2684
Misses 1549 1549
Partials 9 9
|
Hyperkid123
approved these changes
Apr 10, 2024
| @@ -16,6 +16,7 @@ const AUTH_ALLOWED_ORIGINS = [ | |||
| location.origin, | |||
| /https:\/\/api(?:\.[a-z]+)?\.openshift(?:[a-z]+)?\.com/, | |||
| /https:\/\/api?\.demo-experience(?:\.[a-z]+)?\.demo?\.redhat?\.com/, | |||
| /https:\/\/api?\.aws?\.ap-southeast-1(?:\.[a-z]+)?\.openshift?\.com/, | |||
There was a problem hiding this comment.
Just a note. We should start thinking about OCP env variables and pass this list down from chrome.
There was a problem hiding this comment.
@aneelac22 There will be many new regional endpoints following the pattern api.<PROVIDER>.<REGION>.<ENV>.openshift.com with <ENV> being omitted for production. Can we make this more generic so that we don't have to request a change for each new region?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.