RHCLOUD-32008: create internal jotai state for preview #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an internal state variable via jotai to track if preview is enabled or disabled. Tested locally by adding a sub in the store with a console log (see screenshots). The state is correctly toggled with the preview toggle and initialized when chrome loads.
florkbr
commented
May 10, 2024
| @@ -0,0 +1,11 @@ | |||
| import { WritableAtom, atom } from 'jotai'; | |||
|
|
|||
| // recipe from https://jotai.org/docs/recipes/atom-with-toggle | |||
There was a problem hiding this comment.
@Hyperkid123 thoughts on including this? This allows us to eventually toggle the atom value without the need for checking isBeta() in the future.
There was a problem hiding this comment.
Eventually yes, but now with the URL and local storage being in play its a bit too early for it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2832 +/- ##
==========================================
+ Coverage 63.54% 63.63% +0.08%
==========================================
Files 199 201 +2
Lines 4301 4314 +13
Branches 777 778 +1
==========================================
+ Hits 2733 2745 +12
- Misses 1559 1560 +1
Partials 9 9
|
Hyperkid123
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an internal state variable via jotai to track if preview is enabled or disabled.
Tested locally by adding a sub in the store with a console log (see screenshots). The state is correctly toggled with the preview toggle and initialized when chrome loads.
Preview disabled
Preview enabled