Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed title and route in Notifications menu #2847

Merged
merged 1 commit into from
May 28, 2024

Conversation

radekkaluzik
Copy link
Contributor

Change link title from "View event log" to "View notifications log" and change routing from "/settings/notifications/eventlog" to "/settings/notifications/notificationslog"

https://issues.redhat.com/browse/RHCLOUD-32790

Before:
image

After:
image

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 63.61%. Comparing base (f1bd75c) to head (9d5c294).

Current head 9d5c294 differs from pull request most recent head a6f2ca1

Please upload reports for the commit a6f2ca1 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2847   +/-   ##
=======================================
  Coverage   63.61%   63.61%           
=======================================
  Files         201      201           
  Lines        4318     4318           
  Branches      778      778           
=======================================
  Hits         2747     2747           
  Misses       1562     1562           
  Partials        9        9           
Files Coverage Δ
...ponents/NotificationsDrawer/DrawerPanelContent.tsx 4.76% <0.00%> (ø)

@radekkaluzik
Copy link
Contributor Author

/retest

@Hyperkid123 Hyperkid123 merged commit e7a8e07 into RedHatInsights:master May 28, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants