Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jotai migration isFeedbackModalOpen #2860

Merged
merged 8 commits into from
Jun 14, 2024
Merged

Conversation

JetyAdam
Copy link
Contributor

RHCLOUD-33174

@JetyAdam JetyAdam requested a review from a team June 11, 2024 15:05
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.66%. Comparing base (1731eef) to head (3fb8203).

Current head 3fb8203 differs from pull request most recent head 065ef1a

Please upload reports for the commit 065ef1a to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2860      +/-   ##
==========================================
+ Coverage   62.91%   63.66%   +0.75%     
==========================================
  Files         206      207       +1     
  Lines        4509     4503       -6     
  Branches      845      845              
==========================================
+ Hits         2837     2867      +30     
+ Misses       1661     1625      -36     
  Partials       11       11              
Files Coverage Δ
src/chrome/create-chrome.ts 47.61% <100.00%> (+2.49%) ⬆️
src/components/Feedback/FeedbackModal.tsx 49.05% <100.00%> (+43.50%) ⬆️
src/components/Feedback/usePendoFeedback.ts 100.00% <100.00%> (+50.00%) ⬆️
src/redux/action-types.ts 100.00% <ø> (ø)
src/redux/actions.ts 64.86% <ø> (-1.81%) ⬇️
src/redux/chromeReducers.ts 53.96% <ø> (+3.26%) ⬆️
src/redux/index.ts 100.00% <ø> (ø)
src/state/atoms/feedbackModalAtom.ts 100.00% <100.00%> (ø)
src/state/chromeStore.ts 100.00% <100.00%> (ø)

src/chrome/create-chrome.ts Outdated Show resolved Hide resolved
src/components/Feedback/FeedbackModal.tsx Outdated Show resolved Hide resolved
src/components/Feedback/usePendoFeedback.ts Outdated Show resolved Hide resolved
src/components/Feedback/usePendoFeedback.ts Show resolved Hide resolved
src/state/atoms/feedbackModalAtom.ts Outdated Show resolved Hide resolved
src/redux/store.d.ts Outdated Show resolved Hide resolved
src/redux/store.d.ts Outdated Show resolved Hide resolved
@Hyperkid123 Hyperkid123 merged commit 3af37c6 into RedHatInsights:master Jun 14, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants