-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jotai migration activeApp #2866
Jotai migration activeApp #2866
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2866 +/- ##
==========================================
+ Coverage 63.09% 63.27% +0.18%
==========================================
Files 210 211 +1
Lines 4644 4659 +15
Branches 914 857 -57
==========================================
+ Hits 2930 2948 +18
- Misses 1667 1700 +33
+ Partials 47 11 -36
|
febf850
to
a49ea34
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code seems to be good. However, this has the potential to mess up. I'll do some extra local test runs with apps on router v5 to see if nothing broke.
Please don't merge this before that.
OK. I tried it with v5 apps locally. Its working well. @JetyAdam can you remove the old comments? This can be merged after that. |
https://issues.redhat.com/browse/RHCLOUD-33325