Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jotai migration activeApp #2866

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

JetyAdam
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.

Project coverage is 63.27%. Comparing base (d17fb3d) to head (e245e8e).

Current head e245e8e differs from pull request most recent head c30af18

Please upload reports for the commit c30af18 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2866      +/-   ##
==========================================
+ Coverage   63.09%   63.27%   +0.18%     
==========================================
  Files         210      211       +1     
  Lines        4644     4659      +15     
  Branches      914      857      -57     
==========================================
+ Hits         2930     2948      +18     
- Misses       1667     1700      +33     
+ Partials       47       11      -36     
Files Coverage Δ
src/components/ChromeLink/ChromeLink.tsx 73.91% <100.00%> (ø)
src/components/RootApp/ScalprumRoot.tsx 76.25% <100.00%> (+0.60%) ⬆️
src/redux/action-types.ts 100.00% <ø> (ø)
src/redux/actions.ts 62.85% <ø> (-2.01%) ⬇️
src/redux/chromeReducers.ts 54.09% <ø> (+0.13%) ⬆️
src/redux/index.ts 100.00% <ø> (ø)
src/state/atoms/activeAppAtom.ts 100.00% <100.00%> (ø)
src/state/chromeStore.ts 100.00% <100.00%> (ø)
src/utils/consts.ts 85.29% <100.00%> (+12.79%) ⬆️
src/utils/useOuiaTags.ts 100.00% <100.00%> (ø)
... and 1 more

... and 18 files with indirect coverage changes

src/redux/index.ts Show resolved Hide resolved
@Hyperkid123
Copy link
Contributor

/retest

Copy link
Contributor

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems to be good. However, this has the potential to mess up. I'll do some extra local test runs with apps on router v5 to see if nothing broke.

Please don't merge this before that.

src/components/ChromeLink/ChromeLink.tsx Outdated Show resolved Hide resolved
src/state/atoms/activeAppAtom.ts Outdated Show resolved Hide resolved
@Hyperkid123
Copy link
Contributor

Hyperkid123 commented Jun 28, 2024

OK. I tried it with v5 apps locally. Its working well. @JetyAdam can you remove the old comments? This can be merged after that.

@Hyperkid123 Hyperkid123 merged commit 9b05c69 into RedHatInsights:master Jun 28, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants