Filter in notifications drawer #2875
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2875 +/- ##
==========================================
+ Coverage 63.67% 63.69% +0.01%
==========================================
Files 202 202
Lines 4650 4658 +8
Branches 858 859 +1
==========================================
+ Hits 2961 2967 +6
- Misses 1679 1681 +2
Partials 10 10
|
CodyWMitchell
requested review from
Hyperkid123,
ryelo,
karelhala and
florkbr
as code owners
| id: string; | ||
| name: string; | ||
| displayName: string; | ||
| children: null | Bundle[]; |
There was a problem hiding this comment.
I think children can be optional children?: Bundle[]. Or is there is a specific need for the null value?
There was a problem hiding this comment.
Good catch! I think you're right.
| @@ -124,7 +136,23 @@ const DrawerPanelBase = ({ innerRef }: DrawerPanelProps) => { | |||
| ); | |||
| } | |||
| }; | |||
| const fetchFilterConfig = async () => { | |||
There was a problem hiding this comment.
Why is this function defined in useEffect?
There was a problem hiding this comment.
I was following how the permissions were fetched after mounted became true in the fetchPermissions method.
There was a problem hiding this comment.
I see. The pattern used before is wrong. The mounted variable should be in ref so we don't have to do this. Its something for a future refactoring I guess.
RHCLOUD-29014
/api/notifications/v1/notifications/facets/bundles