Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mark-down to notifications drawer #2891

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Add mark-down to notifications drawer #2891

merged 1 commit into from
Jul 4, 2024

Conversation

radekkaluzik
Copy link
Contributor

@radekkaluzik radekkaluzik requested a review from fhlavac July 3, 2024 12:46
@radekkaluzik radekkaluzik requested a review from a team July 3, 2024 12:46
@radekkaluzik
Copy link
Contributor Author

/retest

@Hyperkid123
Copy link
Contributor

Hyperkid123 commented Jul 4, 2024 •
edited
Loading

The library does not have CJS output

 /home/runner/work/insights-chrome/insights-chrome/node_modules/react-markdown/index.js:9

You will have to transform it in jest env

@radekkaluzik radekkaluzik force-pushed the RHCLOUD-29370 branch 4 times, most recently from 1ca342f to 2e61e5f Compare July 4, 2024 12:48
@aneelac22 aneelac22 merged commit 7a19bed into RedHatInsights:master Jul 4, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aneelac22 aneelac22 aneelac22 approved these changes

@Hyperkid123 Hyperkid123 Hyperkid123 approved these changes

@fhlavac fhlavac Awaiting requested review from fhlavac

@ryelo ryelo Awaiting requested review from ryelo ryelo is a code owner

@karelhala karelhala Awaiting requested review from karelhala karelhala is a code owner

@florkbr florkbr Awaiting requested review from florkbr florkbr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radekkaluzik @Hyperkid123 @karelhala @aneelac22