Remove 'My User Access' from Tools dropdown #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwinchell
requested review from
Hyperkid123,
ryelo,
karelhala and
florkbr
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2941 +/- ##
===========================================
- Coverage 65.96% 47.22% -18.75%
===========================================
Files 215 114 -101
Lines 4769 2577 -2192
Branches 929 457 -472
===========================================
- Hits 3146 1217 -1929
+ Misses 1573 951 -622
- Partials 50 409 +359
Flags with carried forward coverage won't be shown. Click here to find out more. |
Hyperkid123
approved these changes
Sep 24, 2024
| @@ -83,9 +83,6 @@ const Tools = () => { | |||
|
|
|||
| const isNotificationsEnabled = useFlag('platform.chrome.notifications-drawer'); | |||
|
|
|||
| const enableMyUserAccessLanding = useFlag('platform.chrome.my-user-access-landing-page'); | |||
There was a problem hiding this comment.
The feature flag should be removed from unleash if we are no longer using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/RHCLOUD-34707
Old
New
