Remove unecessary renders after auth refresh. #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyperkid123
requested review from
ryelo,
karelhala and
florkbr
as code owners
Hyperkid123
force-pushed
the
auth-rendering-audit
branch
2 times, most recently
from
174417d
to
af10aaa
Compare
fhlavac
reviewed
Sep 24, 2024
fhlavac
approved these changes
Sep 24, 2024
Hyperkid123
force-pushed
the
auth-rendering-audit
branch
from
6914ec3
to
7e18ae8
Compare
Hyperkid123
force-pushed
the
auth-rendering-audit
branch
from
7e18ae8
to
4065564
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/RHCLOUD-35374
Changes
Lifting calls to the internal auth context to prevent the tree re-renders. Also memoizing some of the public API objects to prevent extra re-renders.