Skip to content
This repository has been archived by the owner on Feb 4, 2025. It is now read-only.

Adding HTTP API metrics #100

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Conversation

joselsegura
Copy link
Collaborator

Description

Adding HTTP API metrics

Fix CCXDEV-2223

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation update

Testing steps

Regular CI

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #100 into master will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   73.00%   73.15%   +0.14%     
==========================================
  Files           9        9              
  Lines         363      365       +2     
==========================================
+ Hits          265      267       +2     
  Misses         79       79              
  Partials       19       19              
Impacted Files Coverage Δ
server/endpoints.go 100.00% <100.00%> (ø)
server/server.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453d1b7...1f3ef67. Read the comment docs.

Copy link

@Serhii1011010 Serhii1011010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, didn't look at *.html, tho.

@joselsegura joselsegura merged commit a61272f into RedHatInsights:master Jul 8, 2020
@joselsegura joselsegura deleted the metrics branch July 8, 2020 15:10
@joselsegura
Copy link
Collaborator Author

Looks great, didn't look at *.html, tho.

Me neither. Luckily it is autogenerated :-D

Bee-lee pushed a commit to Bee-lee/insights-content-service that referenced this pull request Jul 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants