Skip to content
This repository has been archived by the owner on Feb 4, 2025. It is now read-only.

Removing HTTPS support from code and tests #131

Merged

Conversation

joselsegura
Copy link
Collaborator

Description

Remove the support for HTTPS from configuration, implementation and tests that used it. Also deleting the certificates because it won't be used.

Fixes #48

Type of change

  • Refactor (refactoring code, removing useless files)

Testing steps

Regular CI

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #131 into master will decrease coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   74.47%   74.27%   -0.21%     
==========================================
  Files           9        9              
  Lines         384      381       -3     
==========================================
- Hits          286      283       -3     
  Misses         79       79              
  Partials       19       19              
Impacted Files Coverage Δ
server/server.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca2ccd...14b4c19. Read the comment docs.

@joselsegura joselsegura merged commit 0d4eb2c into RedHatInsights:master Aug 6, 2020
@joselsegura joselsegura deleted the remove_https_support branch August 6, 2020 08:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for HTTPS/TLS as it will be part of smart proxy
4 participants