Skip to content
This repository has been archived by the owner on Feb 4, 2025. It is now read-only.

Keep the list of groups #142

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

joselsegura
Copy link
Collaborator

Description

This change add the prepared list of groups to the server instance in order to prevent its regeneration for each request

Fixes #135

Type of change

  • Refactor (refactoring code, removing useless files)

Testing steps

Regular CI

@codecov-commenter
Copy link

Codecov Report

Merging #142 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   73.47%   73.54%   +0.07%     
==========================================
  Files           9        9              
  Lines         377      378       +1     
==========================================
+ Hits          277      278       +1     
  Misses         81       81              
  Partials       19       19              
Impacted Files Coverage Δ
server/server.go 100.00% <ø> (ø)
server/handlers.go 46.66% <100.00%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e9f63b...fa89a2b. Read the comment docs.

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@joselsegura joselsegura merged commit 98d60f4 into RedHatInsights:master Sep 1, 2020
@joselsegura joselsegura deleted the keep_group_list branch September 1, 2020 13:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants