fix-143

[Serhii1011010]

Description

Fixes #143

Type of change

• Bug fix (non-breaking change which fixes an issue)

Testing steps

make before_commit

[tisnik]

LGTM!
(probably the first use of continue in our code? :)

[Serhii1011010]

@tisnik not really :)

> ./grep --include="*.go" -ir 'continue'
insights-content-service/content/content.go:                                    continue
insights-results-aggregator/consumer/benchmark_test.go:                                 continue
insights-results-aggregator/consumer/benchmark_test.go:                                 continue
insights-results-aggregator/conf/configuration.go:                      continue // skip header
insights-results-smart-proxy/server/handlers.go:                        continue
insights-results-smart-proxy/server/handlers.go:                        continue
insights-results-smart-proxy/conf/configuration.go:                     continue // skip header
insights-results-smart-proxy/content/parsing.go:                                continue

[codecov-commenter]

Codecov Report

Merging #152 into master will decrease coverage by 0.54%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
- Coverage   70.78%   70.23%   -0.55%     
==========================================
  Files           9        9              
  Lines         332      336       +4     
==========================================
+ Hits          235      236       +1     
- Misses         78       81       +3     
  Partials       19       19              

Impacted Files	Coverage Δ
content-service.go	42.85% <0.00%> (-1.47%)	⬇️
content/content.go	84.00% <100.00%> (+0.12%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35cc065...f17eb1d. Read the comment docs.

[joselsegura]

./grep: don't you have it installed properly? :-D

About the commit, LGTM

@tisnik not really :)

> ./grep --include="*.go" -ir 'continue'
insights-content-service/content/content.go:                                    continue
insights-results-aggregator/consumer/benchmark_test.go:                                 continue
insights-results-aggregator/consumer/benchmark_test.go:                                 continue
insights-results-aggregator/conf/configuration.go:                      continue // skip header
insights-results-smart-proxy/server/handlers.go:                        continue
insights-results-smart-proxy/server/handlers.go:                        continue
insights-results-smart-proxy/conf/configuration.go:                     continue // skip header
insights-results-smart-proxy/content/parsing.go:                                continue

[tisnik]

./grep: don't you have it installed properly? :-D

About the commit, LGTM

@tisnik not really :)

> ./grep --include="*.go" -ir 'continue'
insights-content-service/content/content.go:                                    continue
insights-results-aggregator/consumer/benchmark_test.go:                                 continue
insights-results-aggregator/consumer/benchmark_test.go:                                 continue
insights-results-aggregator/conf/configuration.go:                      continue // skip header
insights-results-smart-proxy/server/handlers.go:                        continue
insights-results-smart-proxy/server/handlers.go:                        continue
insights-results-smart-proxy/conf/configuration.go:                     continue // skip header
insights-results-smart-proxy/content/parsing.go:                                continue

Ah, at least we have just few fallthroughs (all written by me, oh :-o )

[Serhii1011010]

./grep: don't you have it installed properly? :-D

@joselsegura, I do ;)

> cat grep
#!/usr/bin/env bash

# TODO: fix colors issue(there's no colors in the output)

grep --exclude-dir="docs/" "$@"