Skip to content
This repository has been archived by the owner on Feb 4, 2025. It is now read-only.

moved-some-types-to-operator-utils #160

Conversation

Serhii1011010
Copy link

Description

Blocked by RedHatInsights/insights-operator-utils#122

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (refactoring code, removing useless files)

Testing steps

make before_commit

@Serhii1011010 Serhii1011010 force-pushed the moved-some-types-to-operator-utils branch from 2d7e999 to 7b0629d Compare October 16, 2020 13:06
Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok (given the utils will be updated before)

@Serhii1011010
Copy link
Author

@tisnik, they are actually already there :)

Copy link
Collaborator

@Bee-lee Bee-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

Codecov Report

Merging #160 into master will not change coverage.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   70.23%   70.23%           
=======================================
  Files           9        9           
  Lines         336      336           
=======================================
  Hits          236      236           
  Misses         81       81           
  Partials       19       19           
Impacted Files Coverage Δ
content/content.go 84.00% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0839237...610a292. Read the comment docs.

@quarckster quarckster merged commit 0f360ce into RedHatInsights:master Oct 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants