This repository has been archived by the owner on Feb 4, 2025. It is now read-only.
Group config parsing #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joselsegura
requested review from
tisnik,
Bee-lee,
bond95,
natiiix,
quarckster and
Serhii1011010
tisnik
approved these changes
May 8, 2020
There was a problem hiding this comment.
Very nice @joselsegura. The startService might use loggging instead of fmt, but it is really nitpick at this moment. TYVM
|
Yes, sure... Probably I won't need to even log it. It was only for "testing" purposes and I forgot to remove before pushing :-D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds the first functionality for the service, allowing it to load a YAML configuration file with the groups definitions in an structured way
Type of change