This repository has been archived by the owner on Feb 4, 2025. It is now read-only.
Remove parsing of error key's condition field #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epapbak
requested review from
Bee-lee,
dpensi,
joselsegura,
matysek,
quarckster and
tisnik
as code owners
tisnik
reviewed
Jun 14, 2021
epapbak
force-pushed
the
remove_metadata_condition
branch
from
d7ef42d to
7233357
Compare
It is, it is =) |
epapbak
force-pushed
the
remove_metadata_condition
branch
from
7233357 to
a55e695
Compare
epapbak
force-pushed
the
remove_metadata_condition
branch
from
a55e695 to
2dbc776
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Condition field has been deprecated from the provided rules. This commit removes the related code in this service.
Fixes #255
Type of change
Testing steps
Running UTs + testing the service manually
Checklist
make before_commitpasses