This repository has been archived by the owner on Feb 4, 2025. It is now read-only.
Add test rules and serve them with update_rules_content.sh --include-test-rules
#329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epapbak
requested review from
Bee-lee,
dpensi,
joselsegura,
juandspy,
matysek and
tisnik
as code owners
epapbak
force-pushed
the
test_rules_with_different_risks
branch
from
0dbbaac to
0522750
Compare
joselsegura
approved these changes
Nov 23, 2021
Bee-lee
reviewed
Nov 23, 2021
rules/test/content/test_rule/TEST_RULE_MODERATE_IMPACT/metadata.yaml
Outdated
Show resolved
Hide resolved
epapbak
force-pushed
the
test_rules_with_different_risks
branch
from
0522750 to
e074829
Compare
Bee-lee
reviewed
Nov 23, 2021
Thanks for the feedback! Truth is I copied the tutorial rule's directory structure. I didn't test without the rules implementation. I'll test it, and if it doesn't break, I'll remove them. |
epapbak
force-pushed
the
test_rules_with_different_risks
branch
from
fbfa98d to
1c52864
Compare
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
=======================================
Coverage 72.58% 72.58%
=======================================
Files 11 11
Lines 580 580
=======================================
Hits 421 421
Misses 134 134
Partials 25 25 Continue to review full report at Codecov.
|
tisnik
reviewed
Nov 23, 2021
epapbak
force-pushed
the
test_rules_with_different_risks
branch
from
1c52864 to
fd6072d
Compare
- Remove unnecessary config.yaml file - use `node_id: null` in plugin - remove rule implementation files (not needed in content service) - style fixes
epapbak
force-pushed
the
test_rules_with_different_risks
branch
from
fd6072d to
b66bf1f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When implementing notification services BDD testcases, the need for specifying rules with a concrete category of impact appeared. These "test rules" serve that purpose, and allow use to not disclose private data in the BDD tests.
The new rules have specific impact and likelihood that ensure we have one rule of each total risk category.
In order for the content-service to serve these new rules, the
update_rules_content.shscript now accepts the--include-test-rulesparameter. This is intended for local use only.Type of change
Testing steps
Please describe how the change was tested locally. If, for some reason, the testing was not done or not done fully, please describe what are the testing steps.
Checklist
make before_commitpasses