Skip to content
This repository has been archived by the owner on Feb 4, 2025. It is now read-only.

[CCXDEV-6834] Show the ocp rules version in /info #402

Merged
merged 3 commits into from
Jul 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,7 @@ commit=$(git rev-parse HEAD)

utils_version=$(go list -m github.com/RedHatInsights/insights-operator-utils | awk '{print $2}')

go build -ldflags="-X 'main.BuildTime=$buildtime' -X 'main.BuildVersion=$version' -X 'main.BuildBranch=$branch' -X 'main.BuildCommit=$commit' -X 'main.UtilsVersion=$utils_version'"
ocp_rules_version=$(grep "^FROM quay.io\/cloudservices\/.* AS rules$" Dockerfile | awk -F'FROM quay.io/cloudservices/| AS rules' '{print $2}')

go build -ldflags="-X 'main.BuildTime=$buildtime' -X 'main.BuildVersion=$version' -X 'main.BuildBranch=$branch' -X 'main.BuildCommit=$commit' -X 'main.UtilsVersion=$utils_version' -X 'main.OCPRulesVersion=$ocp_rules_version'"
exit $?
7 changes: 7 additions & 0 deletions content-service.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ var (
// UtilsVersion contains currently used version of
// github.com/RedHatInsights/insights-operator-utils package
UtilsVersion = "*not set*"

// OCPRulesVersion contains currently used version of
// https://gitlab.cee.redhat.com/ccx/ccx-rules-ocp package
OCPRulesVersion = "*not set*"
)

// startService starts service and returns error code
Expand Down Expand Up @@ -125,6 +129,7 @@ func fillInInfoParams(params map[string]string) {
params["BuildBranch"] = BuildBranch
params["BuildCommit"] = BuildCommit
params["UtilsVersion"] = UtilsVersion
params["OCPRulesVersion"] = OCPRulesVersion
}

func printInfo(msg, val string) {
Expand All @@ -137,6 +142,7 @@ func printVersionInfo() ExitCode {
printInfo("Branch:", BuildBranch)
printInfo("Commit:", BuildCommit)
printInfo("Utils version:", UtilsVersion)
printInfo("OCP rules version:", OCPRulesVersion)
return ExitStatusOK
}

Expand Down Expand Up @@ -207,6 +213,7 @@ func logVersionInfo() {
initInfoLog("Branch: " + BuildBranch)
initInfoLog("Commit: " + BuildCommit)
initInfoLog("Utils version:" + UtilsVersion)
initInfoLog("OCP rules version:" + OCPRulesVersion)
}

const helpMessageTemplate = `
Expand Down
3 changes: 2 additions & 1 deletion content-service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -199,12 +199,13 @@ func TestFillInInfoParams(t *testing.T) {
main.FillInInfoParams(m)

// preliminary test if Go Universe is still ok
assert.Len(t, m, 5, "Map should contains exactly five items")
assert.Len(t, m, 6, "Map should contains exactly six items")

// does the map contain all expected keys?
assert.Contains(t, m, "BuildVersion")
assert.Contains(t, m, "BuildTime")
assert.Contains(t, m, "BuildBranch")
assert.Contains(t, m, "BuildCommit")
assert.Contains(t, m, "UtilsVersion")
assert.Contains(t, m, "OCPRulesVersion")
}