Skip to content
This repository has been archived by the owner on Feb 4, 2025. It is now read-only.

Clean up unused haberdasher vars and references #403

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

joselsegura
Copy link
Collaborator

Description

Minor change removing haberdasher references from the deployment files and Dockerfile

Fixes #CCXDEV-8680

Type of change

  • Refactor (refactoring code, removing useless files)

Testing steps

Not at all, just removing unused vars

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #403 (8ec2727) into master (bd122b5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #403   +/-   ##
=======================================
  Coverage   72.68%   72.68%           
=======================================
  Files          11       11           
  Lines         582      582           
=======================================
  Hits          423      423           
  Misses        134      134           
  Partials       25       25           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd122b5...8ec2727. Read the comment docs.

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joselsegura joselsegura merged commit e5314f7 into master Jul 15, 2022
@tisnik tisnik deleted the cleanup_haberdasher branch April 25, 2023 15:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants