Skip to content
This repository has been archived by the owner on Feb 4, 2025. It is now read-only.

[CCXDEV-10215] CI: Use openapi-generator-cli docker image instead of installing it #498

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

epapbak
Copy link
Collaborator

@epapbak epapbak commented Jul 21, 2023

Description

Use the docker image provided by the OpenApiTools organization instead of installing the openapi-generator-cli every time a PR is verified.

The installation seems to fail quite often due to downtimes of the repository used to verify and download the jar file used by the verification tool.

The issue does not seem to have been fixed yet. See OpenAPITools/openapi-generator-cli#680 and OpenAPITools/openapi-generator#9349. So using the docker image allows us to use the tool without interacting with the "failing" repository.

Fixes CCXDEV-10215

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing steps

CI

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (cff2d4c) 73.46% compared to head (5234027) 73.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #498   +/-   ##
=======================================
  Coverage   73.46%   73.46%           
=======================================
  Files          11       11           
  Lines         603      603           
=======================================
  Hits          443      443           
  Misses        135      135           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@epapbak
Copy link
Collaborator Author

epapbak commented Jul 21, 2023

/retest

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok let's try this

@epapbak epapbak merged commit 784cc1d into RedHatInsights:master Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants