Skip to content
This repository has been archived by the owner on Feb 4, 2025. It is now read-only.

Minor helper fix in order to use operator-utils helpers #70

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

joselsegura
Copy link
Collaborator

Description

Due to changes on insights-operator-utils and its tests/helpers package, some changes are needed in the services

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing steps

Regular CI

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@natiiix natiiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, this makes sense!

@codecov-commenter
Copy link

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   80.49%   80.49%           
=======================================
  Files           8        8           
  Lines         323      323           
=======================================
  Hits          260      260           
  Misses         49       49           
  Partials       14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c60ff6...b18673d. Read the comment docs.

@joselsegura joselsegura merged commit 8a50319 into RedHatInsights:master Jun 11, 2020
@joselsegura joselsegura deleted the minor_helper_fix branch June 11, 2020 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants