fix(InventoryTable): RHINENG-8413 - Bump fec to fix BulkSelect #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastilian
commented
May 6, 2024
| toggleProps: { | ||
| children: isBulkLoading ? ( | ||
| [ | ||
| <Fragment key="sd"> | ||
| <Spinner size="sm" /> | ||
| <Spinner size="md" /> |
There was a problem hiding this comment.
The smoll version was tiny bit too tiny and was barely visible.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2192 +/- ##
==========================================
- Coverage 57.15% 57.13% -0.02%
==========================================
Files 207 207
Lines 6404 6402 -2
Branches 1788 1786 -2
==========================================
- Hits 3660 3658 -2
Misses 2744 2744 ☔ View full report in Codecov by Sentry. |
bastilian
force-pushed
the
bump_fec_bulkselect
branch
3 times, most recently
from
aebf4da
to
b81bdc2
Compare
bastilian
commented
May 7, 2024
| </Fragment>, | ||
| ] | ||
| ) : calculateSelected() > 0 ? ( | ||
| <span id="bulk-select-systems-toggle-checkbox-text">{`${calculateSelected()} selected`}</span> |
There was a problem hiding this comment.
The count prop accomplishes that already. So, we only need/should pass in the loading state when really needed.
bastilian
force-pushed
the
bump_fec_bulkselect
branch
2 times, most recently
from
387d44c
to
8ab8dcf
Compare
bastilian
force-pushed
the
bump_fec_bulkselect
branch
from
8ab8dcf
to
b494ee0
Compare
|
/retest |
1 similar comment
|
/retest |
6 tasks
|
/retest |
|
🎉 This PR is included in version 1.74.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of frontend-components fixes the Spinner in the BulkSelect when loading all IDs.
bulk_select_spinner.mp4