Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RHINENG-9035): bulk select all icon fixed #1182

Merged
merged 1 commit into from
May 13, 2024

Conversation

mkholjuraev
Copy link
Contributor

Description

Associated Jira ticket: #944 tps://issues.redhat.com/browse/RHINENG-9035

Fixes the loading icon in bulk select by updating the fec-config package. It also includes tiny changes to cleanup bulk select config. The icons on systems tables will be fixed by RedHatInsights/insights-inventory-frontend#2192

How to test the PR

  1. Navigate to Advisories table
  2. Select all items in the table
  3. Observe that there is now the spinner icon while items are being selected and selection dropdown is disabled

Before the change

After the change

Dependent work link

Checklist:

  • The commit message has the Jira ticket linked
  • PR has a short description
  • Screenshots before and after the change are added
  • Tests for the changes have been added
  • README.md is updated if necessary
  • Needs additional dependent work

@mkholjuraev mkholjuraev requested a review from a team as a code owner May 9, 2024 13:58
@mkholjuraev
Copy link
Contributor Author

/retest

Copy link
Member

@bastilian bastilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @mkholjuraev!

@mkholjuraev mkholjuraev merged commit 6d3c8de into RedHatInsights:master May 13, 2024
2 checks passed
@mkholjuraev
Copy link
Contributor Author

🎉 This PR is included in version 1.67.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants