Husky #944
Husky #944
Conversation
| #!/usr/bin/env sh | ||
| . "$(dirname -- "$0")/_/husky.sh" | ||
|
|
||
| npm run test && npm run test:ct && npm run lint |
There was a problem hiding this comment.
Woah, do you really want to run component tests too? :-D folks will be crazy waiting for tests to complete. better just leave it on per-pull-request CI?
There was a problem hiding this comment.
I think everyone runs component tests before pushing to CI. Usually what I do is run the tests to check if tests are passing, if not update tests&snapshots and then push to master.
There was a problem hiding this comment.
With this, you will be sure that your PR does not fail tests&lint once and always after you create a PR.
There was a problem hiding this comment.
Also you can easly disable husky while creating a WIP commit with -n or --no-verify
There was a problem hiding this comment.
ok, I see, still sometimes you'd need to commit quickly, but the flag should help. lgtm 👍🏼
|
🎉 This PR is included in version 1.59.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Associated Jira ticket: # (issue)
This is nice to have. It introduces husky to run tests before each commit is created.
How to test the PR
Create any commit and observe that tests are run directly after it got created.
Before the change
After the change
Dependent work link
Checklist: