Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHCLOUD-36014] Test: No replication call for group without principals #1302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Nov 13, 2024

Link(s) to Jira

Description of Intent of Change(s)

Test that replication method was not called when there are no principals in group to migrate

Local Testing

Checklist

  • if API spec changes are required, is the spec updated?
  • are there any pre/post merge actions required? if so, document here.
  • are theses changes covered by unit tests?
  • if warranted, are documentation changes accounted for?
  • does this require migration changes?
    • if yes, are they backwards compatible?
  • is there known, direct impact to dependent teams/components?
    • if yes, how will this be handled?

Secure Coding Practices Checklist Link

Secure Coding Practices Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@lpichler lpichler changed the title Test: No replication call for group without principals [RHCLOUD-36014] Test: No replication call for group without principals Nov 13, 2024
@lpichler lpichler force-pushed the test_no_replicate_method_was_called_in_group_migrator branch from b8bffa6 to 5d56e24 Compare November 13, 2024 06:03
@lpichler lpichler requested a review from astrozzc November 15, 2024 08:06
@alechenninger
Copy link
Collaborator

alechenninger commented Nov 15, 2024

This will probably require changing the test in the #1291, because that exhaustively checks all tuples in the store. That's fine, we'd just have to update to account for another tenant.

That said, if you moved the additional tenant set up into the new test, it should be isolated.

Copy link
Collaborator

@alechenninger alechenninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scratch my last comment – the test I mentioned previously uses a different test class so it doesn't matter. Thanks for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants