-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHCLOUD-30751 Principal endpoint link & test fixes #1399
Open
EvanCasey13
wants to merge
17
commits into
RedHatInsights:master
Choose a base branch
from
EvanCasey13:principal_link_fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
RHCLOUD-30751 Principal endpoint link & test fixes #1399
EvanCasey13
wants to merge
17
commits into
RedHatInsights:master
from
EvanCasey13:principal_link_fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rbac into principal_link_fix
…rbac into principal_link_fix
…ed tests that contained offset + limit params
EvanCasey13
changed the title
RHCLOUD-30751 Principal Links endpoint fixes
RHCLOUD-30751 Principal endpoint link & test fixes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link(s) to Jira
https://issues.redhat.com/browse/RHCLOUD-30751
Description of Intent of Change(s)
Updated the principals endpoint to use common pagination & fixed tests that contained offset and limit.
Issue with testing was only one principal would be created for the test but the offset was 30 and limit was 10 meaning the created principal object would be skipped and not appear in the data of the response as the objects taken started from 30 and was limited to 40.
Local Testing
How can the feature be exercised?
How can the bug be exploited and fix confirmed?
Is any special local setup required?
Checklist
Secure Coding Practices Checklist Link
Secure Coding Practices Checklist