Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HTTP server structure from aggregator #12

Merged
merged 1 commit into from
May 28, 2020
Merged

Adding HTTP server structure from aggregator #12

merged 1 commit into from
May 28, 2020

Conversation

joselsegura
Copy link
Collaborator

Description

HTTP server structure and very basic functionality copied&tuned from the aggregator.

Fixes #11

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update
  • Refactor (refactoring code, removing useless files)
  • Unit tests (no changes in the code)

Testing steps

Regular CI

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@4ed913a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #12   +/-   ##
=========================================
  Coverage          ?   19.30%           
=========================================
  Files             ?        9           
  Lines             ?      430           
  Branches          ?        0           
=========================================
  Hits              ?       83           
  Misses            ?      335           
  Partials          ?       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ed913a...0b1d9a8. Read the comment docs.

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is partially also my code, LGTM :D

@@ -14,7 +14,7 @@
# limitations under the License.

# this is improper - we need to start using tags in GitHub properly
version=0.5
version=0.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can tag and release v0.1:)

Copy link

@natiiix natiiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
If it compiles, it's probably ok. 👍

Copy link

@Serhii1011010 Serhii1011010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to move it to a library or something

@joselsegura
Copy link
Collaborator Author

@tisnik partially? You are too humble :-D

@Sergey1011010 I tried a different approach, trying to define an "HTTPServer" interface or something, but at the end the TLS, authentication and CORS stuff will be only used in the smart proxy and not in the others HTTP servers, so I don't know if it has a lot of sense to put all of that in a common place

@joselsegura joselsegura merged commit 1cbe42e into RedHatInsights:master May 28, 2020
@joselsegura joselsegura deleted the http_server branch May 28, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement basic HTTP server based on aggregator
6 participants