-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding HTTP server structure from aggregator #12
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
=========================================
Coverage ? 19.30%
=========================================
Files ? 9
Lines ? 430
Branches ? 0
=========================================
Hits ? 83
Misses ? 335
Partials ? 12 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is partially also my code, LGTM :D
@@ -14,7 +14,7 @@ | |||
# limitations under the License. | |||
|
|||
# this is improper - we need to start using tags in GitHub properly | |||
version=0.5 | |||
version=0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can tag and release v0.1:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If it compiles, it's probably ok. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to move it to a library or something
@tisnik partially? You are too humble :-D @Sergey1011010 I tried a different approach, trying to define an "HTTPServer" interface or something, but at the end the TLS, authentication and CORS stuff will be only used in the smart proxy and not in the others HTTP servers, so I don't know if it has a lot of sense to put all of that in a common place |
Description
HTTP server structure and very basic functionality copied&tuned from the aggregator.
Fixes #11
Type of change
Testing steps
Regular CI