Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New endpoint returning all rule IDs #137

Merged
merged 5 commits into from
Jul 29, 2020
Merged

New endpoint returning all rule IDs #137

merged 5 commits into from
Jul 29, 2020

Conversation

joselsegura
Copy link
Collaborator

Description

Adding a /rules endpoint to retrieve the list of rule IDs. It also checks the organization ID to retrieve only external rules or include the internal ones too

Type of change

  • New feature (non-breaking change which adds functionality)

Testing steps

regular CI

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2020

Codecov Report

Merging #137 into master will increase coverage by 1.78%.
The diff coverage is 82.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   47.53%   49.31%   +1.78%     
==========================================
  Files          12       12              
  Lines         993     1022      +29     
==========================================
+ Hits          472      504      +32     
+ Misses        462      460       -2     
+ Partials       59       58       -1     
Impacted Files Coverage Δ
server/server.go 50.31% <60.00%> (-0.63%) ⬇️
server/handlers.go 36.00% <75.00%> (+13.77%) ⬆️
content/content.go 74.69% <100.00%> (+7.00%) ⬆️
server/endpoints.go 100.00% <100.00%> (ø)
server/auth.go 49.29% <0.00%> (+9.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 720cb52...2fbf015. Read the comment docs.

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in overall, just pls. look at comments

Copy link

@natiiix natiiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I don't see any obvious issues. 👍

@joselsegura joselsegura merged commit e73b590 into RedHatInsights:master Jul 29, 2020
@joselsegura joselsegura deleted the get_rule_ids branch September 27, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants