-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New endpoint returning all rule IDs #137
Conversation
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 47.53% 49.31% +1.78%
==========================================
Files 12 12
Lines 993 1022 +29
==========================================
+ Hits 472 504 +32
+ Misses 462 460 -2
+ Partials 59 58 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in overall, just pls. look at comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; I don't see any obvious issues. 👍
Description
Adding a /rules endpoint to retrieve the list of rule IDs. It also checks the organization ID to retrieve only external rules or include the internal ones too
Type of change
Testing steps
regular CI