Fix #151 #155
Merged
Fix #151 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joselsegura
requested review from
Bee-lee,
bond95,
natiiix,
quarckster,
Serhii1011010 and
tisnik
as code owners
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
=======================================
Coverage 49.21% 49.21%
=======================================
Files 12 12
Lines 1024 1024
=======================================
Hits 504 504
Misses 461 461
Partials 59 59 Continue to review full report at Codecov.
|
tisnik
approved these changes
Jul 31, 2020
content/content.go
Outdated
| @@ -121,6 +122,7 @@ func (s *RulesWithContentStorage) GetRuleIDs() []string { | |||
| ruleIDs = append(ruleIDs, ruleContent.Plugin.PythonModule) | |||
| } | |||
|
|
|||
| sort.Strings(ruleIDs) | |||
There was a problem hiding this comment.
I think it's better to sort when comparing in tests
There was a problem hiding this comment.
I think about it and you are right. I just modified it
quarckster
approved these changes
Aug 3, 2020
Serhii1011010
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem is caused because the list returned by the
rule_idsendpoint is generated from amap, so its order is not granted.This fix orders the output using
sort, making the result predictableFixes #151
Type of change
Testing steps
Regular CI