Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a proxy function instead a redirect as handler #17

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Using a proxy function instead a redirect as handler #17

merged 1 commit into from
Jun 2, 2020

Conversation

joselsegura
Copy link
Collaborator

Description

This commit makes that smart proxy perform requests to content service and aggregator and then return the response to the client.

Fixes #16

Type of change

  • Refactor (refactoring code, removing useless files)

Testing steps

Regular CI

@codecov-commenter
Copy link

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is 52.94%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   20.31%   20.31%           
=======================================
  Files           9        9           
  Lines         507      507           
=======================================
  Hits          103      103           
  Misses        391      391           
  Partials       13       13           
Impacted Files Coverage Δ
server/endpoints.go 60.00% <52.94%> (ø)
server/server.go 20.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd3768...bd7874a. Read the comment docs.

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Serhii1011010 Serhii1011010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@joselsegura joselsegura merged commit 455a646 into RedHatInsights:master Jun 2, 2020
@joselsegura joselsegura deleted the proxy_instead_of_redirect branch June 2, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants