Added descriptions and examples for get_vote endpoint parameters #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joselsegura
requested review from
Bee-lee,
bond95,
natiiix,
quarckster,
Serhii1011010 and
tisnik
as code owners
tisnik
requested changes
Aug 4, 2020
openapi.json
Outdated
| }, | ||
| { | ||
| "name": "ruleId", | ||
| "in": "path", | ||
| "required": true, | ||
| "description": "Enables a rule (ruleId) for cluster (clusterId) for current organization/user", |
There was a problem hiding this comment.
this does not look like a proper description
There was a problem hiding this comment.
Updated. Copy&paste error
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
=======================================
Coverage 49.28% 49.28%
=======================================
Files 12 12
Lines 1051 1051
=======================================
Hits 518 518
Misses 474 474
Partials 59 59 Continue to review full report at Codecov.
|
tisnik
approved these changes
Aug 4, 2020
quarckster
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added description for get_vote endpoint parameters
Fixes #125 and fixes #124
Type of change
Testing steps
Regular CI